Repository navigation
ci: run helm unittest on all charts - #966
Open
marcleblanc2 wants to merge 4 commits into
Open
marcleblanc2 wants to merge 4 commits into
marcleblanc2 wants to merge 4 commits into
Conversation
- scripts/ci/helm-unittest.sh only tested charts/sourcegraph; pass all four charts so the executor and migrator charts are tested too - drop -q, which is --failfast in helm-unittest and hid every failure after the first - the dind executor tests still targeted the pre-#876 chart (executor.Service.yaml, executor.enabled, registry Deployment + PVC) and had never run in CI; rewrite them for the current templates Amp-Thread-ID: https://ampcode.com/threads/T-01a156fc-33c6-7408-8f03-c6410e72484a Co-authored-by: Amp <amp@ampcode.com>
- cover the Job name suffix, default and overridden args, database secret wiring (default and existingSecret), migrator.env, and priorityClassName precedence - TEST.md: show the all-charts helm unittest command CI uses and where each chart's tests live Amp-Thread-ID: https://ampcode.com/threads/T-01a156fc-33c6-7408-8f03-c6410e72484a Co-authored-by: Amp <amp@ampcode.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Prose is reflowed and the three long shell commands use line continuations; no wording changes. Amp-Thread-ID: https://ampcode.com/threads/T-01a156fc-33c6-7408-8f03-c6410e72484a Co-authored-by: Amp <amp@ampcode.com>
…chart Checkov's secrets scanner (CKV_SECRET_6) flagged my-pgsql-secret as a high-entropy string; my-secret matches the sourcegraph chart's tests and is not flagged. Amp-Thread-ID: https://ampcode.com/threads/T-01a156fc-33c6-7408-8f03-c6410e72484a Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
changed the title
marcleblanc2
enabled auto-merge (squash)
October 20, 2026 07:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #930 / #944, which made
scripts/ci/lint.shcover every chart; nowscripts/ci/helm-unittest.shalso unit tests each charthelm unittest. The plugin already runs every chart after a failure, prints a per-chart summary, and exits non-zero if any chart failed, so no bash bookkeeping is needed.-q. In helm-unittest that flag is--failfast, not quiet, so it stopped at the first failing test and hid the restcharts/sourcegraph-migrator, covering the Job's random name suffix, default and overriddenargs, the three databasesecretKeyRefs (default names and a per-databaseexistingSecretoverride),migrator.env, andpriorityClassNameprecedence (service over global, unset by default)TEST.mdnow shows the all-chartshelm unittestcommand CI uses and where each chart's tests livecharts/sourcegraph-executor/dindtests had never run in CI and still targeted the chart as it was before feat(dind): multi-queue support, Docker mode fixes, and gVisor sandbox support #876:executor/executor.Service.yaml,executor.enabled, and a registry Deployment + PVC, none of which exist anymore. Rewrote them for the current templates: ConfigMap +executor-<queueName>Deployment withEXECUTOR_QUEUE_NAME, one Deployment perqueues[]entry, and the registry StatefulSet + Service gated onprivateDockerRegistry.enabled.Amp-Thread-ID: https://ampcode.com/threads/T-01a156fc-33c6-7408-8f03-c6410e72484a
Checklist
CI, test, and TEST.md-only change, no chart templates or values touched, so no changelog or update-doc entry.
Test plan
Before, on
main, the dind chart fails on its own:After, the script run with the plugin already installed (helm-unittest v1.0.2, helm 4.3.0):
Negative checks: breaking the migrator template's codeintel secret wiring and priorityClassName precedence fails 3 of the 8 new migrator tests. Changing one dind assertion to a wrong Deployment name makes the script exit 1 while the other three charts still run and report.
bash -n scripts/ci/helm-unittest.shpasses.