Add mapping between values key and names used for multi-word resources

[caugustus-sourcegraph]

Goal: I need to be able to reference the auto-generated database secret by name. The secret name is hardcoded (which is not ideal) but even if it were generated, the same problem would occur (example: we would still need to be able to predict the "codeintel-db" section of this line).

My untested hack to use snakecase $service to convert codeIntelDB to codeintel-db didn't work (it produces code-intel-db, of course).

This approach is pretty much me admitting defeat: I can't think of a better way to map codeIntelDB to codeintel-db. It's a little goofy putting this mapping into the values.yaml since it's not intended to be customized, but maybe leaving it in un-documented will be sufficient?

Checklist

• Follow the manual testing process

Test plan

A followup PR actually generates the correct secret references

[michaellzc]

I ran into a similar problem in #52 (comment)

deploy-sourcegraph-helm/charts/sourcegraph/templates/_helpers.tpl

Lines 41 to 46 in 1a6d3ab

	{{- define "sourcegraph.serviceAccountName" -}}
	{{- $top := index . 0 }}
	{{- $service := index . 1 }}
	{{- $defaultServiceAccountName := ((snakecase $service) | replace "_" "-") }}
	{{- default $defaultServiceAccountName (index $top.Values $service "serviceAccount" "name") }}
	{{- end }}

What's your thought on introducing another breaking change? e.g., we rename the values codeInsightDB -> codeintelDb?

If not, I think we should update serviceAccoutName partial template to follow the same conventino.

[caugustus-sourcegraph]

@michaellzc Actually I realized I'm dumb for introducing a new variable - couldn't we just prepopulate codeIntelDB.name with codeintel-db, instead of adding codeIntelDB.mappingName? And then your serviceAccountName logic could be simpler too:

 {{- $defaultServiceAccountName := (index $top.Values $service "name")
 {{- default $defaultServiceAccountName (index $top.Values $service "serviceAccount" "name") }} 

[michaellzc]

@michaellzc Actually I realized I'm dumb for introducing a new variable - couldn't we just prepopulate codeIntelDB.name with codeintel-db, instead of adding codeIntelDB.mappingName? And then your serviceAccountName logic could be simpler too:

 {{- $defaultServiceAccountName := (index $top.Values $service "name")
 {{- default $defaultServiceAccountName (index $top.Values $service "serviceAccount" "name") }} 

🙃 I was dumb too.

Yes!

[caugustus-sourcegraph]

Great work everyone, we discovered this is a bad idea