Add day-of-week and localized-date display options#2516
Open
teras wants to merge 1 commit into
Open
Conversation
Two independent, opt-in additions to how dates are shown everywhere: - Day of week: a dropdown in Preferences > General (None / Short / Full) that prepends ddd/dddd to the active date format. Stored as DayOfWeekStyle; day names come from the active culture. - Localized dates: a toggle that ties day/month names to the application's selected language (UseLocalizedCulture) instead of the invariant/English culture. The culture is derived from the app locale key, not the operating-system culture. Both options flow through DateTimeFormat.Format and are bound into the CommitTimeTextBlock and DateTimePresenter views. New locale keys added to en_US and el_GR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sometimes you need to see the weekday of a commit, not just the date — especially when reasoning about workdays, where knowing it was e.g. a Friday matters as much as the calendar date itself. The current display only shows the date.
Also, while the app interface can be localized, the date is always rendered in English, which doesn't help users running the app in their own language. It is preferable to let the date follow the user's language too, when they want it.
Both options are opt-in and were kept deliberately non-intrusive — placed where there is already space and where they make sense in Preferences.
What
Day of week — a dropdown in Preferences ▸ General (None / Short / Full) that prepends
ddd/ddddto the active date format. Stored asDayOfWeekStyle; day names come from the active culture.Localized dates — a toggle (
UseLocalizedCulture) that ties day/month names to the application's selected language instead of the invariant/English culture. The culture is derived from the app locale key, not the OS culture.Both flow through
DateTimeFormat.Formatand are bound intoCommitTimeTextBlockandDateTimePresenter. New locale keys added toen_USandel_GR.