refactor(chore): remove Node js 20 support - #18
Conversation
remove Node js 20 support BREAKING CHANGE: yes GH-17
| "undici": "6.24.0", | ||
| "axios": "1.15.0" | ||
| "axios": "1.16.0", | ||
| "form-data":"4.0.4" |
There was a problem hiding this comment.
Two things here beyond the Node 20 removal (which is fine):
-
Scope creep — this PR also bumps
axios 1.15.0 → 1.16.0and addsform-data 4.0.4, under a commit titled "remove Node js 20 support". These look like dependency/security bumps, but they're unrelated to the Node-version change and aren't mentioned in the description. Better as a separatefix(deps)PR so the node-removal stays a clean, reviewable chore and the dep bumps get their own justification/changelog. -
enginesvs lockfile mismatch (applies to all the node-20 PRs, not just this one) —package.jsonhas"engines": { "node": "22 || 24" }, but the regeneratedpackage-lock.jsonroot still says"node": ">=22". The lockfile was generated when package.json said>=22, then engines was changed to22 || 24without re-runningnpm install. Pick one and regenerate so they match. I'd suggest">=22"for a published library —"22 || 24"silently excludes Node 23 and every future LTS (26, 28…), so the package would refuse to install on the next LTS until another PR bumps it. Don't over-constrain consumers.
Nit: "form-data":"4.0.4" is missing the space after the colon (line 92) — inconsistent with "axios": "1.16.0" right above it.
rohit-sourcefuse
left a comment
There was a problem hiding this comment.
Node 20 removal is fine. Two items in the inline comment: (1) the engines↔lockfile mismatch (package.json "22 || 24" vs lockfile ">=22" — regenerate; suggest ">=22" for a library), and (2) the axios/form-data bumps are scope creep for a node-version PR — better split into a fix(deps) PR. No blocker, just worth tidying before merge.
remove Node js 20 support BREAKING CHANGE: yes GH-17
SonarQube reviewer guideSummary: Drops support for Node.js 20, updates project version to 1.0.3, and modernizes dependencies with numerous package updates across the stack. Review Focus: The key changes are the removal of Node.js 20 from the CI matrix and the corresponding engine constraint change from Start review at:
|
rohit-sourcefuse
left a comment
There was a problem hiding this comment.
Engines/lockfile match now and checks are green — approving. The axios/form-data bumps are still bundled in this PR; not blocking, but ideally split into a separate fix(deps) PR next time so the node-version chore stays clean.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |



remove Node js 20 support
BREAKING CHANGE:
yes
GH-17
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist:
Build:
Test: