Skip to content

refactor(chore): remove Node js 20 support - #18

Merged
yeshamavani merged 2 commits into
masterfrom
GH-17
Jun 16, 2026
Merged

refactor(chore): remove Node js 20 support#18
yeshamavani merged 2 commits into
masterfrom
GH-17

Conversation

@Sourav-kashyap

Copy link
Copy Markdown
Contributor

remove Node js 20 support

BREAKING CHANGE:
yes

GH-17

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build:

Screenshot 2026-06-11 at 3 15 46 PM

Test:

Screenshot 2026-06-11 at 3 16 18 PM

remove Node js 20 support

BREAKING CHANGE:
yes

GH-17
@Sourav-kashyap Sourav-kashyap self-assigned this Jun 11, 2026
@Sourav-kashyap Sourav-kashyap linked an issue Jun 11, 2026 that may be closed by this pull request
Comment thread package.json Outdated
"undici": "6.24.0",
"axios": "1.15.0"
"axios": "1.16.0",
"form-data":"4.0.4"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things here beyond the Node 20 removal (which is fine):

  1. Scope creep — this PR also bumps axios 1.15.0 → 1.16.0 and adds form-data 4.0.4, under a commit titled "remove Node js 20 support". These look like dependency/security bumps, but they're unrelated to the Node-version change and aren't mentioned in the description. Better as a separate fix(deps) PR so the node-removal stays a clean, reviewable chore and the dep bumps get their own justification/changelog.

  2. engines vs lockfile mismatch (applies to all the node-20 PRs, not just this one)package.json has "engines": { "node": "22 || 24" }, but the regenerated package-lock.json root still says "node": ">=22". The lockfile was generated when package.json said >=22, then engines was changed to 22 || 24 without re-running npm install. Pick one and regenerate so they match. I'd suggest ">=22" for a published library — "22 || 24" silently excludes Node 23 and every future LTS (26, 28…), so the package would refuse to install on the next LTS until another PR bumps it. Don't over-constrain consumers.

Nit: "form-data":"4.0.4" is missing the space after the colon (line 92) — inconsistent with "axios": "1.16.0" right above it.

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 20 removal is fine. Two items in the inline comment: (1) the engines↔lockfile mismatch (package.json "22 || 24" vs lockfile ">=22" — regenerate; suggest ">=22" for a library), and (2) the axios/form-data bumps are scope creep for a node-version PR — better split into a fix(deps) PR. No blocker, just worth tidying before merge.

remove Node js 20 support

BREAKING CHANGE:
yes

GH-17
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Drops support for Node.js 20, updates project version to 1.0.3, and modernizes dependencies with numerous package updates across the stack.

Review Focus: The key changes are the removal of Node.js 20 from the CI matrix and the corresponding engine constraint change from >=20 to 22 || 24. Additionally, there are significant dependency updates including Babel 7.29.x versions, updated LoopBack packages, and critical security/compatibility updates to packages like body-parser, express, and various CLI tools. Pay close attention to the breaking change in body-parser's content-type handling and any API changes in upgraded dependencies.

Start review at: .github/workflows/main.yaml and package.json. These files document the platform support strategy and dependency versioning decisions, which directly impact both CI/CD configuration and runtime compatibility across the supported Node.js versions.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rohit-sourcefuse rohit-sourcefuse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engines/lockfile match now and checks are green — approving. The axios/form-data bumps are still bundled in this PR; not blocking, but ideally split into a separate fix(deps) PR next time so the node-version chore stays clean.

@yeshamavani
yeshamavani merged commit e3377b4 into master Jun 16, 2026
6 checks passed
@yeshamavani
yeshamavani deleted the GH-17 branch June 16, 2026 10:22
@yeshamavani

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove Node.js 20 support

3 participants