Skip to content

feat(chore): support retrieval of invoice PDF download URLs#28

Open
Sourav-kashyap wants to merge 1 commit intomasterfrom
GH-27
Open

feat(chore): support retrieval of invoice PDF download URLs#28
Sourav-kashyap wants to merge 1 commit intomasterfrom
GH-27

Conversation

@Sourav-kashyap
Copy link
Copy Markdown

@Sourav-kashyap Sourav-kashyap commented May 4, 2026

Description

This change introduces enhancements for invoice data access and payment-related operations.

Changes

  • Added support for retrieving invoice PDF download URLs
  • Added functionality to fetch payment method details associated with invoices
  • Introduced payment intent operations:
  • Retrieve payment intents by ID for payment tracking

PDF Invoice using Stripe:

Using.Stripe.mov

PDF Invoice using Chargebee:

Using.Chargebee.mov

support retrieval of invoice PDF download URLs

GH-27
@Sourav-kashyap Sourav-kashyap self-assigned this May 4, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

SonarQube reviewer guide

Summary: Add invoice PDF download functionality to both ChargeBee and Stripe services with comprehensive unit tests.

Review Focus:

  • Error handling differs between providers (ChargeBee checks download_url existence; Stripe checks invoice_pdf field and handles draft invoices)
  • Type assertions in ChargeBee implementation due to SDK limitations
  • Ensure TInvoicePdf interface properly handles optional expiresAt field since Stripe doesn't expose expiry times

Start review at: src/types.ts. This defines the TInvoicePdf interface that both service implementations depend on, and adding it to the IService interface establishes the contract that both providers must follow. Understanding the data structure first will clarify the implementation differences.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant