Skip to content

build-subsets.sh skips cleanup of an existing temporary source directory #740

Description

@dajiaohuang

build-subsets.sh appears to skip cleanup when the temporary source directory already exists:

if ! [ -d "$TEMP_SOURCE" ]; then
    rm -rf $TEMP_SOURCE
fi
mkdir $TEMP_SOURCE

When source/temp is left by an interrupted or previously failed run, the condition is false, so the directory is not removed and the following mkdir fails. Please invert the condition (or remove the directory unconditionally before recreating it) and add a repeat-build regression check. The relevant lines are 169-175 on the current default branch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions