feat(repeat): revive repeat_pattern as generic repeat_apply - #910
Merged
Conversation
Rune's repeat_pattern applied a closure to a value n times, but it was rune-specific (asserted the result stayed a Rune after each step) even though the underlying n-times-application logic is generic. It was removed from the rune bundle in #888. Bring it back as repeat_apply in the repeat module, with no rune dependency, and with arguments reordered to (func, n, x) to match the existing repeat(func, n) signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repeat_patternapplied a closure to a value n times, but it was rune-specific (asserting the result stayed aRuneafter each step) even though the underlying n-times-application logic is generic. It was removed from the rune bundle in docs/enhancement: fix landing page, sound/scrabble docs, remove rune's repeat_pattern #888 with a note that this belongs in therepeatmodule.repeat_applyin therepeatmodule: no rune dependency, arguments reordered to(func, n, x)to match the existingrepeat(func, n)signature.Test plan
yarn tscpasses insrc/bundles/repeatyarn testpasses (8/8, including newrepeat_applycases: n-times application, n=0 identity, negative/non-integernerror)yarn lintpasses🤖 Generated with Claude Code
https://claude.ai/code/session_01Q3x3dGYsWpd1QfJaA9h3Za