Various fixes #86
Open
Various fixes #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
commented
Nov 28, 2025
| type = new(opts) | ||
| constraints = | ||
| case type.constraints do | ||
| {:and, constraints} -> {:and, constraints ++ infer_constraints(predicates)} |
Contributor
Author
There was a problem hiding this comment.
I made the minimal changes to make this work. But it looks like {:and, constraints} gets treated the same as just constraints, so I wonder if we can just get rid of {:and, ...} everywhere.
uhoreg
commented
Nov 28, 2025
| @doc since: "0.1.0" | ||
|
|
||
| @spec type({atom(), []}) :: type() | ||
| @spec type({atom(), list()}) :: type() |
Contributor
Author
There was a problem hiding this comment.
The Elixir docs say that a typespec of [] means an empty list.
uhoreg
commented
Nov 28, 2025
|
|
||
| defp constrain(%Drops.Types.Cast{input_type: input_type} = type, predicates) do | ||
| Map.merge(type, %{ | ||
| input_type: constrain(input_type, predicates) |
Contributor
Author
There was a problem hiding this comment.
I wasn't sure if the constraint should be applied to the input type, the output type, or both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors with certain schemas. I don't remember exactly what the schemas were that caused the errors. One of them was a union where one of the types was a custom type that was a cast or a union itself.