Skip to content

Bump discard requirement#6488

Open
jarednorman wants to merge 1 commit into
solidusio:mainfrom
SuperGoodSoft:discard-2
Open

Bump discard requirement#6488
jarednorman wants to merge 1 commit into
solidusio:mainfrom
SuperGoodSoft:discard-2

Conversation

@jarednorman
Copy link
Copy Markdown
Member

Discard v2 slightly changes how transactions and callbacks interact to be more consistent with how they work with operations like delete in ActiveRecord. I don't know if we depend on that behaviour, but we should lock ourselves to the more correct behaviour, in case it matters.

Discard v2 slightly changes how transactions and callbacks interact to
be more consistent with how they work with operations like delete in
ActiveRecord. I don't know if we depend on that behaviour, but we should
lock ourselves to the more correct behaviour, in case it matters.
@jarednorman jarednorman requested a review from a team as a code owner May 27, 2026 23:13
@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (4e00cb1) to head (b74d3a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6488   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files         992      992           
  Lines       20846    20846           
=======================================
  Hits        18695    18695           
  Misses       2151     2151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant