Open
Conversation
The menu item still renders as expected in the DOM, just without the `DEPRECATION WARNING: Using the "spree/admin/shared/_promotion_sub_menu" partial is deprecated, please use MenuItem#children instead.` deprecation warning in the logs.
github-actions
bot
added
the
changelog:solidus_legacy_promotions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The menu item still renders as expected in the DOM, just without the
DEPRECATION WARNING: Using the "spree/admin/shared/_promotion_sub_menu" partial is deprecated, please use MenuItem#children instead.deprecation warning in the logs.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: