Skip to content

Conversation

@jarednorman
Copy link
Member

@jarednorman jarednorman commented Jan 8, 2026

Summary

Core itself doesn't care about the presence of sprockets. The starter frontend doesn't need it. I don't think the new admin needs it. I think the old backend does, as does the old frontend.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.50%. Comparing base (1e26db3) to head (a269744).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6404   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files         981      981           
  Lines       20479    20479           
=======================================
  Hits        18329    18329           
  Misses       2150     2150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Core itself doesn't care about the presence of sprockets. Backend
depends on handlebars_assets and sassc-rails, which both depend on
sprockets.
@jarednorman jarednorman force-pushed the fix-sprockets-dependency branch from 6c2460b to a269744 Compare January 8, 2026 19:07
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Jan 8, 2026
@jarednorman jarednorman marked this pull request as ready for review January 8, 2026 19:28
@jarednorman jarednorman requested a review from a team as a code owner January 8, 2026 19:28
@tvdeyen tvdeyen added this to the 4.7 milestone Jan 8, 2026
@jarednorman jarednorman merged commit 714b3ec into solidusio:main Jan 9, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants