Refactor: Move rounding to promotion calculator module#6332
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Oct 23, 2025
Merged
Refactor: Move rounding to promotion calculator module#6332tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
All calculators need to be able to round correctly, and we can centralize that logic.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6332 +/- ##
=======================================
Coverage 89.35% 89.35%
=======================================
Files 961 961
Lines 20195 20195
=======================================
Hits 18046 18046
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adammathys
approved these changes
Oct 14, 2025
jarednorman
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All promotion calculators need to be able to round correctly, and we can centralize that logic.
Extracted from #6287
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: