Repository navigation
Conversation
Each PR passed the size gate alone; combined on next they put the hydrating (no stores), hydrating + stores and compiled hydrating scenarios over their caps (+61 B minified from #4061). Caps set at CI's measurement + 10 B. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KRieFbP8sapvTBygyVm3mg
|
Size (brotli, eager entry chunk)
|
|
Closing: #4065 merged while this was open and shrank the signals core by enough (about −128 B minified on the hydrating scenarios) that all three caps pass again at their current values. The Size check is green on Generated by Claude Code |
Merging this PR will degrade performance by 9.74%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | createStore setter: delete + set one root key (#3044 overlay) |
1.8 ms | 2 ms | -12.03% |
| ❌ | memo + sync render effect only (reference) |
26.6 ms | 28.7 ms | -7.38% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/project-thread-ntysj0 (73a1160) with next (47d2346)1
Requested by Ryan · project thread
Summary
Before: the Size check is red on
nextsince #4059 merged (runs on 2da0f8e and 47d2346). #4059 and #4061 each passed the size gate alone. Together, #4061's +61 B minified client change lands on top of the caps #4059 had just raised, which puts three hydrating scenarios over.After: those three caps are raised to CI's measurement + 10 B, rounded up to 0.01 KB, with ledger entries. No code changes.
The +61 B comes from #4061's
packages/web/src/client.tschange (the #4049 Loading + lazy hydration order fix). That attribution is inferred from #4061 being the only client change in between; the gate reports +0 B over each PR's own base.The "live server components" page stays a warning only: it is 47 B over its brotli cap but 926 B under its recorded minified.
Size-Exception: app: hydrating (no stores) floor 18.09 -> 18.14 KB (+61 B minified, 53,350 -> 53,411) from #4061's Loading + lazy hydration order fix landing on top of #4059's raised cap; restores the Size check on next.
How did you test this change?
pnpm build, thennode size.mjsonnext@ 47d2346 reproduced CI's numbers exactly (18,124 / 29,664 / 31,881 B). With this change all three pass; only the live SC page warns, as on CI.node gate.test.mjspasses. Prettier is clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01KRieFbP8sapvTBygyVm3mg
Generated by Claude Code