Repository navigation
chat example: drop the local-condition workaround, end renders when the tab closes - #4066
Conversation
…he tab closes Live holes no longer stop updating when a condition reads a property (#4023, fixed in #4062), so messageMarkup reads message.usage and friends directly and the README drops the "test locals" rule. server.js now aborts the request and cancels the body when the client disconnects, as server-dbmon does, so a closed tab stops its thread watcher. Both servers stay quiet about the abort. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LZkrATgvFJjgFRdDB4Drcq
|
Size (brotli, eager entry chunk)
|
|
The The growth comes from #4059 (
So Generated by Claude Code |
Coverage Report for CI Build 38632511713Coverage remained the same at 77.515%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will regress 1 benchmark
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | dbmon shallow full tick |
50.4 ms | 53.3 ms | -5.49% |
| ⚡ | createStore setter: delete + set one root key (#3044 overlay) |
2.1 ms | 1.7 ms | +17.17% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/project-thread-271xwi (09f7e43) with next (0109a56)
|
All other checks are green on Generated by Claude Code |
Before: the chat example read
reasoning,errorandusageinto locals before using them in conditions, and its README told readers to do the same. #4023 made that necessary, because a property condition ({message.usage && …}) froze the live hole. Separately, when a tab closed, chat'sserver.jskept its render, and the thread watcher, running.After:
messageMarkupreadsmessage.usage,message.reasoningandmessage.errordirectly, which works since #4062. The README drops the "test locals, not properties" rule.server.jspasses an abort signal to the request and cancels the response body when the client disconnects, as server-dbmon does. Both servers now stay quiet when a closed tab aborts a response, instead of logging the AbortError.How: verified in Chromium by sending a message and checking that the finished reply shows its usage footer (
30 tokens · 2.3s), a property condition that used to stay empty.vite buildand the client-bundle check pass.check:server's "thread was yielded many times" assertion fails the same way onnextwithout this change (db timing).🤖 Generated with Claude Code
https://claude.ai/code/session_01LZkrATgvFJjgFRdDB4Drcq
Generated by Claude Code