Skip to content

Isolate context id space inside createComponent under NoHydration #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeSingh1 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Isolate context id space inside createComponent under NoHydration #2707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/solid/src/server/rendering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,15 @@ export function createUniqueId(): string {
}

export function createComponent<T>(Comp: (props: T) => JSX.Element, props: T): JSX.Element {
if (sharedConfig.context && !sharedConfig.context.noHydrate) {
if (sharedConfig.context) {
// Even under noHydrate we still need to isolate the id space for each
// component, so that `createResource` calls in sibling/nested components
// do not collide on the same context id when a parent `Suspense` resets
// `count` back to 0. Without this, a non-hydrating render of
// `<Post><Suspense><User/></Suspense></Post>` (each with a resource)
// produces two resources sharing the same id key in
// `context.resources` and the inner resource reads back the outer one's
// value. See #2546.
const c = sharedConfig.context;
setHydrateContext(nextHydrateContext());
const r = Comp(props || ({} as T));
Expand Down