Skip to content

fix: resolve solid-element owner marker lookup #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryansolid merged 1 commit into from
May 18, 2026
+11 −8
Merged

fix: resolve solid-element owner marker lookup #2705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-element-owner-markers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"solid-element": patch
---

Fix owner marker lookup so nested custom elements can inherit context from ancestor host markers as well as assigned slot markers.
14 changes: 6 additions & 8 deletions packages/solid-element/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@ function createProps<T extends object>(raw: T) {
function lookupContext(el: ICustomElement & { _$owner?: any }) {
if (el.assignedSlot && el.assignedSlot._$owner) return el.assignedSlot._$owner;
let next: Element & { _$owner?: any } = el.parentNode;
while (
next &&
!next._$owner &&
!(next.assignedSlot && (next.assignedSlot as Element & { _$owner?: any })._$owner)
)
while (next) {
if (next._$owner) return next._$owner;
if (next.assignedSlot && (next.assignedSlot as Element & { _$owner?: any })._$owner)
return (next.assignedSlot as Element & { _$owner?: any })._$owner;
next = next.parentNode as Element;
return next && next.assignedSlot
? (next.assignedSlot as Element & { _$owner?: any })._$owner
: el._$owner;
}
return el._$owner;
}

function withSolid<T extends object>(ComponentType: ComponentType<T>): ComponentType<T> {
Expand Down
Loading