fix(signal): reduce duplicate observer registrations in repeated signal reads#2660
Open
oanlit wants to merge 2 commits intosolidjs:mainfrom
Open
fix(signal): reduce duplicate observer registrations in repeated signal reads#2660oanlit wants to merge 2 commits intosolidjs:mainfrom
oanlit wants to merge 2 commits intosolidjs:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a signal is read repeatedly within the same computation (e.g. inside loops),
the current implementation registers the same observer multiple times.
This leads to unnecessary growth of internal tracking structures, including:
observersobserverSlotssourcessourceSlotsThis issue is especially noticeable in patterns such as:
In these cases, repeated signal reads (e.g.
length, indexed access, or direct signal calls)cause the same computation to be registered multiple times.
This PR introduces a lightweight deduplication mechanism by tracking the last registered observer per signal.
lastObservertoSignalStatelastObserverlastObserverduring cleanupThis significantly reduces redundant registrations in common scenarios while keeping the cost of deduplication O(1) and preserving existing behavior.
How did I test this change?
To enable verification of internal observer behavior in tests, this PR slightly adjusts the return value of
createSignal:Before this change:
observers.length === 1000After this change:
observers.length === 1Confirmed that repeated reads (e.g.
lengthand indexed access) no longercause excessive observer registrations.
pnpm build pnpm testAll tests pass.
observerSlotsandsourceSlotsno longer grow excessively