Skip to content

Comments

add jsdoc to serialization mode#2088

Merged
atilafassina merged 2 commits intofeat-seroval-jsonfrom
seroval-mode-jsdoc
Feb 25, 2026
Merged

add jsdoc to serialization mode#2088
atilafassina merged 2 commits intofeat-seroval-jsonfrom
seroval-mode-jsdoc

Conversation

@atilafassina
Copy link
Member

Porting the JSDoc comment from v1 here.

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2026

⚠️ No Changeset found

Latest commit: 73128c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2088
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2088

commit: 73128c9

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports the v1 JSDoc documentation for the server function/action serialization mode into the SolidStartOptions config type so downstream tooling/IDE hints can expose the option details.

Changes:

  • Added a JSDoc block describing the serialization.mode option and its tradeoffs ("js" vs "json"), including the default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@atilafassina atilafassina merged commit 0e31479 into feat-seroval-json Feb 25, 2026
3 checks passed
@atilafassina atilafassina deleted the seroval-mode-jsdoc branch February 25, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants