Skip to content

update code identifier - unique requirement#56

Merged
tgra merged 2 commits intomainfrom
tgra/acp_typed_code_identifier_update
Apr 22, 2026
Merged

update code identifier - unique requirement#56
tgra merged 2 commits intomainfrom
tgra/acp_typed_code_identifier_update

Conversation

@tgra
Copy link
Copy Markdown
Member

@tgra tgra commented Apr 22, 2026

Type of Change

* [ ] New domain file
* [x ] Update existing domain file
* [ x] Documentation only

If updating:

* [ ] New shape
* [ ] Additional constraints (non-breaking)
* [ ] New version of existing shape

Domain

Domain file: acp_typed.ttl


Shape Details

acp_typed_shape:AcpTypedShape a sh:NodeShape ;
    dc:source <https://github.com/solid/object/blob/main/src/acp/AccessControl.ts> ; 
    prov:wasDerivedFrom <https://github.com/solid/object/blob/main/src/acp/AccessControl.ts> ;
    sh:codeIdentifier "AccessControlPolicyTyped";
    sh:name "ACP Policy Typed Shape";
    dct:created "2026-03-18"^^xsd:date ;
    vs:term_status "testing";


Shape Change

* [ ] New shape
* [ ] New version of existing shape
* [ ] Non-breaking constraint addition
* [x] Documentation update

Description:


Immutability Confirmation

* [ x] Existing constraints were not modified
* [ x] Previously valid data remains valid
* [ ] If behaviour changed, a new shape/version was introduced

Compatibility

* [x ] Fully backwards compatible
* [ ] May cause new validation failures
* [ ] Breaking change

Explanation if needed.


Validation

* [ x] SHACL validation run
* [ ] Example data tested

Tools used:


Reviewer Checklist

* [ ] Immutability respected
* [ ] Targeting is correct
* [ ] Constraints justified
* [ ] Examples match expected behaviour

@tgra
Copy link
Copy Markdown
Member Author

tgra commented Apr 22, 2026

Non-unique code identifier value for node shape created duplicate entries in shacl-converter output index.ts eg

export * from "./AccessControlPolicy";
export * from "./AccessControlPolicy";

@tgra tgra merged commit a48f2db into main Apr 22, 2026
2 checks passed
@tgra tgra deleted the tgra/acp_typed_code_identifier_update branch April 22, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant