Respond with 400 status code if not all request body bytes were received - #5466
Draft
rwalerow wants to merge 1 commit into
Draft
Respond with 400 status code if not all request body bytes were received#5466rwalerow wants to merge 1 commit into
rwalerow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it?
In order to have a test which might confirm an issue
with an incompletely send request
How I did it:
I prepared a new test case in NettyCatsRequestTimeoutTest as following:
set request timeout to 1s
declare 10000 bytes as request body size(content length)
send request with a tiny request body