[Android] Fix hover events recording gestures other than HoverGestureHandler#4220
Open
j-piasecki wants to merge 1 commit into
Open
[Android] Fix hover events recording gestures other than HoverGestureHandler#4220j-piasecki wants to merge 1 commit into
HoverGestureHandler#4220j-piasecki wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Android hover-event handler extraction so that hover events don’t incorrectly “record” non-hover gesture handlers (which could cancel Touchables when TalkBack dispatches hover events for focus), aligning ancestor-handler extraction behavior with existing per-view filtering.
Changes:
- Updated
extractAncestorHandlersto receive theMotionEvent. - Applied existing hover-event filtering (
shouldHandlerSkipHoverEvents) while collecting handlers from ancestor views. - Updated the call site to pass through the
event.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-bert
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extractAncestorHandlerswas registering all handlers when triggered by a hover event, instead of only registeringHoverGestureHandlerinstances. This causedTouchablesto be canceled at the start when using Talkback (which dispatches hover events on focus) due toshouldBeginWithRecordedHandlers.Test plan
Enable Talkback and try to activate any
Touchablein the Expo Example main screen