[Android] Fix wrong reported number of pointers#4218
Open
j-piasecki wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect numberOfPointers reported to JS on Android for ACTION_POINTER_UP events (Android includes the lifted pointer in MotionEvent.pointerCount for that event), aligning the reported pointer count with the number of pointers remaining on screen and preventing pinch “jump” scenarios like #3435.
Changes:
- Adjust
numberOfPointerscalculation on Android to reportpointerCount - 1forACTION_POINTER_UP. - Preserve existing behavior for
ACTION_UP/ACTION_CANCELto stay consistent with iOS behavior as noted in the PR description.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-bert
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3435
Android includes the pointer being lifted in the
ACTION_POINTER_UPevent, so the event where the pointer is lifted is sent withnumberOfPointers = 2. This PR changes that so thenumberOfPointersis reported asn - 1forACTION_POINTER_UPevents.Note: The same applies to
ACTION_UPandACTION_CANCELbut I didn't include them to keep the behavior the same as on iOS.Test plan
Reproducer from #3435