[General] Hide internal fields from gesture events #3844
Merged
+87
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
reviewed
Nov 28, 2025
packages/react-native-gesture-handler/src/v3/types/EventTypes.ts
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/v3/hooks/gestures/fling/useFlingGesture.ts
Outdated
Show resolved
Hide resolved
m-bert
reviewed
Dec 1, 2025
Comment on lines
+98
to
+103
| std::dynamic_pointer_cast<const RNGestureHandlerDetectorEventEmitter>(_eventEmitter) | ||
| ->onGestureHandlerAnimatedEvent({ | ||
| .state = event.state, | ||
| .handlerTag = event.handlerTag, | ||
| .handlerData = event.handlerData, | ||
| }); |
Contributor
There was a problem hiding this comment.
It is only formatting, right? Do we want that in this PR?
Member
Author
There was a problem hiding this comment.
I didn't even notice that. It must have been added by lint-staged.
Member
Author
There was a problem hiding this comment.
I don't mind it, so I'll leave it up to you.
Contributor
There was a problem hiding this comment.
I'd prefer not to have it here as it will affect blame. But if you leave it it will also be fine.
m-bert
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hides internal fields (
state,oldState, andhandlerTag) from the Gesture Handler events exposed externally. Those shouldn't be needed when using the v3 api and clutter the events.This also means that update events don't differ from the update events in shape, so they became redundant.
Test plan
Verify that
state,oldState, andhandlerTagare hidden from events.