Conversation
| 2. Once the PR is merged, `cherry-pick` the commit to the release branch. | ||
| 3. Bump version in `package.json` to the new version `v{MAJOR}.{MINOR}.{REVISION}`. | ||
| Commit with a message 'Release v{MAJOR}.{MINOR}.0'. | ||
| 4. Tag release branch with proper version tag `v{MAJOR}.{MINOR}.{REVISION}` and run `npm publish`. |
There was a problem hiding this comment.
Same mention about workflow should go here
|
|
||
| The release process of new minor version consists of the following steps: | ||
|
|
||
| 1. Bump version in `package.json` to the new version `v{MAJOR}.{MINOR}.0`. |
There was a problem hiding this comment.
Bumping package.json should be done after merging and publishing the current version, so it shouldn't be placed as the first step, right?
|
|
||
| 1. Create a PR to the main branch. | ||
| 2. Once the PR is merged, `cherry-pick` the commit to the release branch. | ||
| 3. Bump version in `package.json` to the new version `v{MAJOR}.{MINOR}.{REVISION}`. |
There was a problem hiding this comment.
I think this commit should not go directly from release branch, but rather goes from private branch into release branch via PR, so we can review these changes before merging into release branch.
| 2. Once the PR is merged, `cherry-pick` the commit to the release branch. | ||
| 3. Bump version in `package.json` to the new version `v{MAJOR}.{MINOR}.{REVISION}`. | ||
| Commit with a message 'Release v{MAJOR}.{MINOR}.0'. | ||
| 4. Tag release branch with proper version tag `v{MAJOR}.{MINOR}.{REVISION}` and run `npm publish`. |
There was a problem hiding this comment.
| 4. Tag release branch with proper version tag, namely: `git tag v{MAJOR}.{MINOR}.{REVISION} && git push origin v{MAJOR}.{MINOR}.{REVISION}` and run `npm publish`. |
There was a problem hiding this comment.
we shouldnt run npm publish
There was a problem hiding this comment.
I didn't updated this npm publish here since my very first comment from this review addresses it :) But yes
There was a problem hiding this comment.
Im not sure which comment you're refering to
2 participants
Description
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes