fix(ci): gate node_modules diagnostic on existing step id#1215
Open
msluszniak wants to merge 1 commit into
Open
fix(ci): gate node_modules diagnostic on existing step id#1215msluszniak wants to merge 1 commit into
msluszniak wants to merge 1 commit into
Conversation
The 'Show packed node_modules' diagnostic in npm-publish.yml was gated on steps.node_modules.outcome, but no step has id 'node_modules' — the check step is 'check_node_modules'. The condition was always undefined, so the diagnostic never ran and a node_modules leak failed the publish without surfacing the offending paths. Fix the id reference and drop the exit-code inversion so the step reports success after printing matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Show packed node_modules" diagnostic in
.github/workflows/npm-publish.ymlwas gated onsteps.node_modules.outcome == 'failure', but no step hasid: node_modules— the check step's id ischeck_node_modules. The condition was therefore always undefined and the diagnostic never ran. On anode_modulesleak the publish job failed (correctly, viacheck_node_modules) but the log showing which paths leaked was silently skipped.This fixes the id reference and drops the exit-code inversion (
!) so the step prints the matching paths and reports success.Introduces a breaking change?
Type of change
Tested on
Testing instructions
CI-only change. Verify the workflow still parses and that the
Show packed node_modulesstep referencessteps.check_node_modules.outcome.Related issues
Closes #1210
Checklist