feat(android): text alignment#602
Open
kacperzolkiewski wants to merge 32 commits into
Open
Conversation
exploIF
reviewed
May 29, 2026
| import com.swmansion.enriched.textinput.utils.getSafeSpanBoundaries | ||
| import com.swmansion.enriched.textinput.utils.safelyInsertZWS | ||
|
|
||
| class AlignmentStyles( |
Collaborator
There was a problem hiding this comment.
Why do we need to have a separate abstraction for alignement? Cannot we reuse what's implemented for the paragraph spans?
Collaborator
There was a problem hiding this comment.
Why do we need to modify logic inside list styles?
| ) { | ||
| val safeStart = start.coerceAtLeast(0) | ||
| val safeEnd = end.coerceAtMost(length) | ||
| if (safeStart >= safeEnd) return |
Collaborator
There was a problem hiding this comment.
In such scenario, shouldn't we use start as end and the other way around?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds text alignment for Android
(Note:
justifyalignment is not natively supported for single spans on Android and will not work).Test Plan
Run example app and play with
textAlignmentwhen different styles are toggled.Check if paragraphs/lists with different
textAlignmentthan auto are properly parsed and containstyle="text-align:center|right"inside HTMLScreenshots / Videos
Screen.Recording.2026-05-20.at.12.06.27.mov
Compatibility
Checklist