Skip to content

Conversation

@mdydek
Copy link
Contributor

@mdydek mdydek commented Nov 13, 2025

Closes RNAA-297

⚠️ Breaking changes ⚠️

Introduced changes

LIST:

  • AudioNode
  • AnalyserNode
  • AudioBufferBaseSourceNode
  • AudioBufferQueueSourceNode
  • AudioBufferSourceNode
  • BiquadFilterNode
  • ConstantSourceNode
  • ConvolverNode
  • GainNode
  • OscillatorNode
  • PeriodicWave
  • StereoPannerNode

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@mdydek mdydek requested a review from Copilot November 13, 2025 17:13
Copilot finished reviewing on behalf of mdydek November 13, 2025 17:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for passing audio node options (channel configuration) in the GainNode constructor, aligning with the Web Audio API specification. The implementation spans TypeScript and C++ layers, introducing new type definitions and updating constructors to accept optional configuration parameters.

  • Introduces TAudioNodeOptions and TGainOptions types for channel configuration
  • Updates GainNode constructor to accept optional configuration parameters
  • Adds C++ parsing logic for audio node options from JavaScript

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/react-native-audio-api/src/types.ts Adds new type definitions TAudioNodeOptions and TGainOptions for audio node configuration
packages/react-native-audio-api/src/interfaces.ts Updates createGain method signature in IBaseAudioContext to accept TGainOptions parameter
packages/react-native-audio-api/src/defaults.ts Defines default values for audio node and gain options
packages/react-native-audio-api/src/core/GainNode.ts Refactors constructor to accept and merge options with defaults before creating the native node
packages/react-native-audio-api/src/core/BaseAudioContext.ts Simplifies createGain method to delegate parameter handling to GainNode constructor
packages/react-native-audio-api/common/cpp/audioapi/core/effects/GainNode.h Updates constructor signature to accept GainOptions parameter
packages/react-native-audio-api/common/cpp/audioapi/core/effects/GainNode.cpp Updates constructor implementation to use options for initializing gain parameter and audio node properties
packages/react-native-audio-api/common/cpp/audioapi/core/BaseAudioContext.h Updates createGain method signature to accept GainOptions parameter
packages/react-native-audio-api/common/cpp/audioapi/core/BaseAudioContext.cpp Updates createGain implementation to pass options to GainNode constructor
packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.h Updates constructor to accept optional AudioNodeOptions parameter
packages/react-native-audio-api/common/cpp/audioapi/core/AudioNode.cpp Implements conditional initialization of channel properties from options
packages/react-native-audio-api/common/cpp/audioapi/HostObjects/utils/NodeOptionsParser.h Adds parsing functions to convert JavaScript option objects to C++ structs
packages/react-native-audio-api/common/cpp/audioapi/HostObjects/utils/NodeOptions.h Defines C++ structs for AudioNodeOptions and GainOptions
packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp Updates JSI binding to parse options from JavaScript before calling createGain

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks promising, @michalsek wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants