Feat/delay node #803
Open
Feat/delay node #803
+443
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vltkv
reviewed
Nov 13, 2025
vltkv
reviewed
Nov 13, 2025
poneciak57
approved these changes
Nov 13, 2025
vltkv
reviewed
Nov 13, 2025
vltkv
approved these changes
Nov 13, 2025
maciejmakowski2003
requested changes
Nov 14, 2025
packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/DelayNode.cpp
Outdated
Show resolved
Hide resolved
maciejmakowski2003
requested changes
Nov 20, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/utils/AudioNodeManager.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/DelayNode.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/DelayNode.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/DelayNode.cpp
Show resolved
Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/DelayNode.cpp
Show resolved
Hide resolved
poneciak57
approved these changes
Nov 21, 2025
michalsek
requested changes
Nov 21, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/effects/DelayNode.cpp
Show resolved
Hide resolved
maciejmakowski2003
approved these changes
Nov 25, 2025
michalsek
reviewed
Nov 26, 2025
Member
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
👍 just please add some new (empty) lines in the delayBufferOperation and processNode to make it more readable
michalsek
approved these changes
Nov 26, 2025
poneciak57
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-320
Introduced changes
DelayNodeChecklist