Skip to content

fix: problems with rendering and detached threads - #1229

Draft
mdydek wants to merge 2 commits into
mainfrom
fix/multi-threaded-problems
Draft

fix: problems with rendering and detached threads#1229
mdydek wants to merge 2 commits into
mainfrom
fix/multi-threaded-problems

Conversation

@mdydek

@mdydek mdydek commented Aug 14, 2026

Copy link
Copy Markdown
Member

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

  • fast suspend and resume in offline audio context could have a slight window when two rendering threads were running in the same time, which could result in multiple consumers of the events
  • removing node lacked self draining
  • promise offloader was destroyed too late in the context destructor which could result in use after free
  • do not create new threads on audio thread, which results in allocation, changed logic or place of creation new thread

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

WPT non-regression comparison

ERROR — the run produced no report.

Workflow run · this comment is updated on every push.

@mdydek mdydek added the fix Code changes specifically addressing and resolving a bug label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Code changes specifically addressing and resolving a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant