dx: Enable eslint-plugin-typegpu in repo#2193
Open
aleksanderkatan wants to merge 15 commits intomainfrom
Open
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (337 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
This PR tightens and extends the repo’s linting setup by enabling eslint-plugin-typegpu via oxlint, failing CI on any lint warnings, and updating the internal eslint plugin package build tooling/config.
Changes:
- Enforce zero lint warnings in CI (
oxlint --max-warnings=0) and bumpoxlintto^1.49.0. - Add
eslint-plugin-typegputo the repo and wire its recommended rules intooxlintvia a newoxlint.config.ts. - Migrate the internal eslint plugin build from
tsuptotsdown, updating configs and package metadata.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds workspace link for eslint-plugin-typegpu, bumps oxlint, adds tsdown and related lock updates. |
| package.json | Adds eslint-plugin-typegpu, bumps oxlint, and enforces --max-warnings=0 for style checks. |
| oxlint.config.ts | New TS-based oxlint config, dynamically pulls eslint-plugin-typegpu recommended rules + registers jsPlugin. |
| .oxlintrc.json | Removes the previous JSON-based oxlint configuration. |
| packages/eslint-plugin/package.json | Switches build to tsdown and updates package exports. |
| packages/eslint-plugin/tsup.config.ts | Removes old tsup config. |
| packages/eslint-plugin/tsdown.config.ts | Adds new tsdown build config for the plugin package. |
| packages/typegpu/tests/std/numeric/div.test.ts | Adds targeted oxlint suppressions for the new integer-division rule in tests. |
| packages/typegpu-three/src/typegpu-node.ts | Avoids unused catch binding by using catch {}. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2185.
Changes:
eslint-plugin-typegpuin our plugin config,