fix(validate): skip azure-mariadb/sql/postgres (validator meterName mismatch)#66
Merged
fix(validate): skip azure-mariadb/sql/postgres (validator meterName mismatch)#66
Conversation
The Azure validator filters upstream by `meterName eq '{resource_name}'`
(pipeline/validate/azure.py:_filter_for_sample), but the Retail API
exposes Azure DB pricing with `meterName="vCore"` and disambiguates via
productName + skuName. Our resource_name (e.g. "Gen5 2 vCore",
"GP_Gen5_2") never matches the upstream meterName, producing 14-19/20
`missing_upstream` and any "found" matches are unrelated line items.
Verified against the public Retail API for service "Azure Database for
MariaDB" / "SQL Database" / "Azure Database for PostgreSQL".
Add to SKIP_REVALIDATION until the Azure validator gains per-shard
product/sku-name matching like it has for App Service / AKS.
Closes #56, #58, #60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why skip rather than fix the matcher now
The proper fix is per-shard filter strategies in `pipeline/validate/azure.py` (similar to the existing App Service / AKS handlers, matching by `productName` + `skuName`). That's a follow-up; this PR stops the daily false-positive drift issues.
Not addressed
Test plan