fix: workflow create command shadowed by generated create#119
Merged
Conversation
Move generated.RegisterAll() and mergeCommand() from init() to Execute() so that all package-level init functions have completed before merging. Previously, root.go's init ran before workflow.go's init (alphabetical order), so mergeCommand saw an empty workflowCmd and copied the generated "create" (raw Jira workflow API) into it. The hand-written "create" (convenience issue creation) was then added as a duplicate and Cobra returned the generated one first.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jr workflow create --project KAN --type Task --summary "..."failed with "unknown flag: --project" because the generatedworkflow create(raw Jira workflow API) shadowed the hand-written convenience commandroot.go'sinit()calledmergeCommand()beforeworkflow.go'sinit()registered subcommands (Go runs inits alphabetically by filename), so the generatedcreatewas copied into the empty hand-writtenworkflowCmdRegisterAll()andmergeCommand()frominit()toExecute(), which runs after allinit()functions completeTest plan
jr workflow create --project KAN --type Task --summary "test"now worksjr workflow get-all)make testpasses (unit, integration, e2e)