[Visual] VisualModelImpl: add data to optionally generate uv coords#6137
Open
fredroy wants to merge 1 commit into
Open
[Visual] VisualModelImpl: add data to optionally generate uv coords#6137fredroy wants to merge 1 commit into
fredroy wants to merge 1 commit into
Conversation
… being forcefully computed in all cases)
alxbilger
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... using UV spherical projection.
This was done automatically if there was no texcoords previously (most certainly from a mesh).
But more often than not, the texcoords are not used so this is wasteful.
same as the previous PR, this is "functionally" breaking because it changes an implicit behavior to an explicit one (with an opposite default value), but I dont want to nag with message like "it was generating texcoords before, if you want to to do it set the data blabalbla"
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if