Skip to content

[Visual] VisualModelImpl: clean apply transformations#6136

Open
fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:clean_visualmodelimpl
Open

[Visual] VisualModelImpl: clean apply transformations#6136
fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:clean_visualmodelimpl

Conversation

@fredroy
Copy link
Copy Markdown
Contributor

@fredroy fredroy commented Jun 2, 2026

and dont commit (i.e call updateVisual) automaticallly.

Every time apply{scale, roatation, translation} was called, a updateVisual() was made.
So in this case for example it was done thrice whereas two calls are useless.

It is a bit breaking functionally but I dont know how to make it "warnable"/deprecated/etc.
I dont think lots of people are extending and modifying this part of the code so it should be not really painful (hopefully 🫢)

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: breaking Change possibly inducing a compilation error pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jun 2, 2026
@fredroy
Copy link
Copy Markdown
Contributor Author

fredroy commented Jun 2, 2026

[ci-build][with-all-tests]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant