Skip to content

[Helper] FileRepository::findFile(): use the list of paths when given a dotted path#6135

Open
fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:fix_findfiles_rel
Open

[Helper] FileRepository::findFile(): use the list of paths when given a dotted path#6135
fredroy wants to merge 1 commit into
sofa-framework:masterfrom
fredroy:fix_findfiles_rel

Conversation

@fredroy
Copy link
Copy Markdown
Contributor

@fredroy fredroy commented Jun 2, 2026

Strangely, findFile, when given a dotted path to find, was not using its own list of paths and only use the current working directory. Which cause problems, especially with python3 scenes

Bonus, renaming the member vpath because it was confusing + using foreach loops

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Jun 2, 2026
@fredroy fredroy force-pushed the fix_findfiles_rel branch from b930dd4 to 40ba4fa Compare June 2, 2026 05:45
@fredroy
Copy link
Copy Markdown
Contributor Author

fredroy commented Jun 2, 2026

[ci-build][with-all-tests]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant