Propagate request trace through logs#123
Open
simonepri wants to merge 1 commit intosoedinglab:masterfrom
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
## Problem MMseqs2-App lost request trace context as soon as work was enqueued, so request-side and worker-side logs could not be correlated reliably. The existing plain-text logs also only exposed `traceparent`, which is harder to parse in systems like SigNoz or Datadog. ## Solution Add an OTEL trace context payload to `JobRequest`, populate it once from HTTP middleware, and pass it through the job constructors so the same context is available when the worker executes the job. Update job-scoped worker logs to append that context, and include explicit `trace_id` and `span_id` fields derived from `traceparent` for easier downstream parsing.
simonepri
force-pushed
the
trace-aware-request-logging
branch
from
e18706e to
dfd2688
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
simonepri
changed the title
simonepri
changed the title
Author
|
@rachelse, @dannydoor could you please take a look at this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MMseqs2-App server does not allow to correlate logs with request ids.
Solution
Add an OTEL trace context payload to
JobRequest, populate it once from HTTP middleware, and pass it through the job constructors so the same context is available when the worker executes the job. Update job-scoped worker logs to append that context, and include explicittrace_idandspan_idfields derived fromtraceparentfor easier downstream parsing.