Add a non-blocking partial peek for layered streams#16
Open
samuel-williams-shopify wants to merge 8 commits into
Open
Add a non-blocking partial peek for layered streams#16samuel-williams-shopify wants to merge 8 commits into
samuel-williams-shopify wants to merge 8 commits into
Conversation
samuel-williams-shopify
force-pushed
the
fix/tls-viability-probe
branch
from
July 25, 2026 07:17
5dea555 to
237a4d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IO::Stream::Readable#peek_partialfor one non-blocking read attempt without consuming application dataclose_notifynilwhen reading would block or reaches EOFHTTP/1 can use this primitive in its protocol-specific connection viability check before reusing an idle connection. This addresses the stale HTTPS connection behavior discussed in socketry/async-http#223 without changing the non-consuming
readable?contract used by HTTP/2.Validation
git diff --checkpassed