Fix native extension build on mswin - #224
Open
hsbt wants to merge 1 commit into
Open
Conversation
There is no `unistd.h`, and the `pipe` emulation macro in `ruby/win32.h` is only visible while building ruby itself, while `HAVE_PIPE` is still defined in its config.h. Guard the include and define `pipe` using `rb_w32_pipe` whenever the macro is missing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing
io-eventon mswin (x64-mswin64_140) fails becauseext/io/event/interrupt.cincludesunistd.h, which MSVC does not ship. Guarding that include is not enough. The existingrb_w32_pipefallback is skipped because ruby's mswinconfig.hdefinesHAVE_PIPE, while thepipemacro inruby/win32.his only visible when building ruby itself.extconf.rbalso never checked forruby/win32.h, so that fallback was dead code.I made
extconf.rbdetectunistd.handruby/win32.h, and changed the fallback to definepipewhenever the macro is missing. The extension now builds with MSVC 14.51, andIO::Event::Selector::Selectworks for a basicio_waiton a pipe. This is independent of the IOCP selector in #188, which leavesinterrupt.cuntouched.Generated with Claude Code