Repository navigation
Fix chess page layout. - #14
Merged
Merged
Conversation
The chess page contents had a max width of 800px set which was squishing all the elements together. This seemed to be derived from a 'scroller' CSS element - I'm not sure how it was being added but it must've been something to do with the 'Scroller' vdom element being created. I removed this element since the chess app doesn't scroll infinitely like the posts page, etc. Anything that does scroll in the app has its own internal scroll handling. I also removed the 'Chess' section title as I don't think this adds anything. I also set a default font size of 14px in the ssb-chess-mithril top element's CSS as the font size was a bit small. There's still a lot of room for improvement in the UI but this at least makes the chat usuable, etc ':D
…ed up the package lock or something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chess page contents had a max width of 800px set which was squishing
all the elements together. This seemed to be derived from a 'scroller'
CSS element - I'm not sure how it was being added but it must've been
something to do with the 'Scroller' vdom element being created. I
removed this element since the chess app doesn't scroll infinitely like
the posts page, etc. Anything that does scroll in the app has its own
internal scroll handling.
I also removed the 'Chess' section title as I don't think this adds
anything. I also set a default font size of 14px in the
ssb-chess-mithril top element's CSS as the font size was a bit small.
There's still a lot of room for improvement in the UI but this at least
makes the chat usuable, etc ':D
Previous
Current