feat: implement SSL and proxy handling for downloads [IDE-1299] #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SSL certificate validation bypass when IgnoreUnknownCA setting is enabled - Add automatic system proxy configuration for CLI downloads - Enhance SnykWebClient to respect SSL and proxy settings from extension options - Enhance SnykCliDownloader to use properly configured HttpClient with SSL and proxy support - Add comprehensive test coverage for SSL and proxy handling functionality - Fix SSL certificate validation not respecting the IgnoreUnknownCA setting during CLI downloads - Fix missing proxy configuration for CLI downloads This ensures that both the --insecure flag and proxy configurations are properly respected throughout the download process, improving compatibility with corporate environments that use custom certificates or proxy servers.
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
had a problem deploying
to
snyk-msbuild-envs
GitHub Actions
Failure
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Move the SSL and proxy handling improvements from [Unreleased] section to version 2.3.0 as requested.
bastiandoetsch
had a problem deploying
to
snyk-msbuild-envs
GitHub Actions
Failure
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
…-1299] Remove redundant proxy configuration since HttpClient and WebClient use system proxy by default. Keep only the essential SSL certificate validation bypass for the --insecure flag (IgnoreUnknownCA setting). Changes: - Remove manual proxy configuration from SnykWebClient and SnykCliDownloader - Keep only SSL certificate validation bypass when IgnoreUnknownCA is enabled - Update tests to focus on essential SSL functionality - Update changelog to reflect simplified approach This results in cleaner, simpler code that relies on .NET's default proxy behavior while still providing the necessary --insecure flag support.
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
had a problem deploying
to
snyk-msbuild-envs
GitHub Actions
Failure
Remove accidentally committed JetBrains IDE configuration files from git tracking and add .idea/ to .gitignore to prevent future commits of IDE-specific files.
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
had a problem deploying
to
snyk-msbuild-envs
GitHub Actions
Failure
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
…IDE-1299] Revert incorrect changes to GetLatestReleaseInfo method that attempted to parse JSON response when the endpoint actually returns a simple version string. The method now correctly: - Downloads version string from the endpoint - Cleans up the response (removes newlines) - Creates LatestReleaseInfo object with the version string Only minimal change kept: passing SnykOptions to SnykWebClient for SSL handling.
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
bastiandoetsch
temporarily deployed
to
snyk-msbuild-envs
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements comprehensive SSL certificate and proxy handling for CLI downloads in the Snyk Visual Studio plugin. The changes ensure that both the --insecure flag and proxy configurations are properly respected throughout the download process, improving compatibility with corporate environments that use custom certificates or proxy servers.
Key Changes:
SnykWebClientto respect SSL and proxy settings from extension optionsSnykCliDownloaderto use properly configuredHttpClientwith SSL and proxy supportIgnoreUnknownCAsetting is enabledFixes:
IgnoreUnknownCAsetting during CLI downloadsThis addresses the requirements to:
✅ Respect the --insecure flag via
IgnoreUnknownCAsetting✅ Handle custom certificates properly through SSL configuration
✅ Use proxy configuration everywhere for downloads
Checklist