fix: filter out configs without deps #321
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Before using a configuration, check that it has resolvable dependencies. Each configuraiton must have at least one firstLevelModuleDependencies that comes from a resolvable configuration. This filters out deprecated configurations, like compile and runtime. By allowing these configurations to be proccesed we incorrectly resolve dependencies for them.
gitphill
force-pushed
the
fix/filter-out-config-with-no-deps
branch
from
ea7dc0e to
d334320
Compare
Contributor
Author
|
i'm not sure we can do this, pretty sure it breaks other setups using custom configurations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Before using a configuration, check that it has resolvable dependencies. Each configuraiton must have at least one firstLevelModuleDependencies that comes from a resolvable configuration.
This filters out deprecated configurations, like compile and runtime.
By allowing these configurations to be processed we incorrectly resolve dependencies for them.