Skip to content

fix: keep CLI-owned retry paths at the application layer [IDE-1890] - #7116

Draft
basti-snyk wants to merge 1 commit into
mainfrom
feat/IDE-1890-cli-retry-path-defaults
Draft

fix: keep CLI-owned retry paths at the application layer [IDE-1890]#7116
basti-snyk wants to merge 1 commit into
mainfrom
feat/IDE-1890-cli-retry-path-defaults

Conversation

@basti-snyk

@basti-snyk basti-snyk commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • declare the CLI's unsafe-method retry paths at the CLI application boundary
  • preserve user-supplied path overrides and keep network retries opt-in
  • pin go-application-framework to the unmerged ownership change

Dependency

This draft pins go-application-framework commit 102bfe6ddf2e17c02e5e878ab3744dc296071e23 (v0.14.2-0.20260812074653-102bfe6ddf2e) from go-application-framework #686, which carries current GAF main so module resolution stays tidy. Do not merge this PR until #686 merges and releases; the dependency reference must then be updated to the released GAF version.

Tracking: IDE-1890

Verification

  • targeted CLI application configuration and engine tests pass
  • golangci-lint run ./... passes
  • public CLI build passes
  • Snyk Code reports no new issues
  • full Go suite was run; unrelated existing assertions in GAF presenter snapshots and CLI instrumentation scrubbing are not caused by this configuration-only diff

@snyk-io

snyk-io Bot commented Aug 12, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@basti-snyk
basti-snyk force-pushed the feat/IDE-1890-cli-retry-path-defaults branch from 4a154da to fea402b Compare August 12, 2026 07:42
go-application-framework no longer ships a default list of paths that may be
replayed on an unsafe HTTP method, so the CLI now declares its own
(test-dep-graph, verify/token, feature_flags/evaluation) during application
configuration. Behaviour is unchanged for every user: retries stay opt-in and
a user-supplied list still wins.

The framework requirement moves to the pseudo-version built from the merge of
current main into that branch, so module resolution no longer needs a newer
release than the pinned commit and go.mod stays tidy.
@basti-snyk
basti-snyk force-pushed the feat/IDE-1890-cli-retry-path-defaults branch from fea402b to 15e0c70 Compare August 12, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant