Skip to content

revert: correct commit used for snyk-ls#6811

Open
rrama wants to merge 1 commit into
mainfrom
revert/snyk-ls
Open

revert: correct commit used for snyk-ls#6811
rrama wants to merge 1 commit into
mainfrom
revert/snyk-ls

Conversation

@rrama
Copy link
Copy Markdown
Contributor

@rrama rrama commented May 15, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

The snyk-ls commit was pointing to a commit on a feature branch, not main.
This happened in #6766.
This commit reverts back to the previous snyk-ls commit CLI was using.

Refs: 36ff328

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 15, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@rrama
Copy link
Copy Markdown
Contributor Author

rrama commented May 15, 2026

May need test/jest/acceptance/language-server-extension.spec.ts reverting to the previous version of the file (use the version at 5927337).
Edit: I did need to do this, so I have done it.

@j-luong j-luong changed the title revert: snyk-ls pointing to bad commit fix: correct commit used for snyk-ls May 15, 2026
@j-luong j-luong changed the title fix: correct commit used for snyk-ls revert: correct commit used for snyk-ls May 15, 2026
@rrama rrama force-pushed the revert/snyk-ls branch from db3fd21 to 3fe33ac Compare May 15, 2026 12:05
@rrama rrama marked this pull request as ready for review May 15, 2026 14:33
@rrama rrama requested review from a team as code owners May 15, 2026 14:33
@snyk-pr-review-bot

This comment has been minimized.

The snyk-ls commit was pointing to a commit on a feature branch, not main.
This happened in #6766.
This commit reverts back to the previous snyk-ls commit CLI was using.
Also reverted the changes to `test/jest/acceptance/language-server-extension.spec.ts` as they are for newer Snyk LS changes.

Refs: 36ff328
@rrama rrama force-pushed the revert/snyk-ls branch from 3fe33ac to 6ab4936 Compare May 15, 2026 16:43
@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 1.00)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant