Skip to content

chore: enable secrets acceptance tests in prod [PS-588]#6803

Open
alexandru-manea-snyk wants to merge 1 commit into
mainfrom
chore/PS-588/enable-secrets-acceptance-tests-in-prod
Open

chore: enable secrets acceptance tests in prod [PS-588]#6803
alexandru-manea-snyk wants to merge 1 commit into
mainfrom
chore/PS-588/enable-secrets-acceptance-tests-in-prod

Conversation

@alexandru-manea-snyk
Copy link
Copy Markdown
Contributor

@alexandru-manea-snyk alexandru-manea-snyk commented May 13, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

Risk assessment (Low | Medium | High)?

  • Low

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 13, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@alexandru-manea-snyk alexandru-manea-snyk force-pushed the chore/PS-588/enable-secrets-acceptance-tests-in-prod branch 2 times, most recently from a7939f3 to b50d89f Compare May 13, 2026 14:34
@alexandru-manea-snyk alexandru-manea-snyk force-pushed the chore/PS-588/enable-secrets-acceptance-tests-in-prod branch from b50d89f to 4cb25b7 Compare May 13, 2026 14:57
@alexandru-manea-snyk alexandru-manea-snyk marked this pull request as ready for review May 14, 2026 13:21
@alexandru-manea-snyk alexandru-manea-snyk requested review from a team as code owners May 14, 2026 13:21
@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Reduced Verification 🟡 [minor]

The refactor of the 'SARIF output payload validation' test removes the validation loop for result suppressions metadata. Previously, the test verified that each suppression contained 'justification', 'kind', and 'status' keys. This check was deleted, meaning the test no longer ensures that ignored secrets are correctly enriched in the SARIF output as claimed by its title.

    foundMultipleLocations = true;
  }
});
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 1.00)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant