Repository navigation
Generate API key auth for Python clients - #960
Merged
Merged
Conversation
arandito
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Python clients now support
httpApiKeyAuth, which is the only auth scheme the Java generator supports. Before this, the generator rejected any operation that needed auth._auth.pyadds an auth registry keyed by trait ID, like the protocol registry. API key auth is the only entry.api_keyandapi_key_identity_resolverfieldsauth_schemesdefaults toAPIKeyAuthScheme, orAsyncAPIKeyAuthSchemein the async configset_auth_schemeDefaultAuthResolver. Java's generatedHTTPAuthSchemeResolverchecksauth_parameters.operation == "Health", butoperationis anAPIOperation, so the check is never true and@auth([])operations get signed. I checked this against Java's output for the new fixture.DefaultAuthResolveruses each operation's effective schemes, so those operations go out unsigned.noAuth, so a bearer-only operation isn't silently sent unsigned.api-key-auth-clientsnapshot, built frommodels/api-key-auth.smithy. Its tests cover a signed operation,@auth([]),@optionalAuth, and a missing key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.