Skip to content

[Mirror of #928] Give every shape its own synthetic operation in python-type-codegen - #953

Closed
stobrien89 wants to merge 2 commits into
developfrom
mirror-pr-928
Closed

stobrien89 wants to merge 2 commits into
developfrom
mirror-pr-928

Conversation

@stobrien89

Copy link
Copy Markdown
Contributor

Issue #, if available: N/A

Description of changes:

Mirrors #928 from a branch in this repo so the aws-sdk-pr-build workflow runs. Not for merging; review and merge #928.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

CreateSyntheticService incremented the operation index only for shapes that
get a synthetic input wrapper, so an error (or a kept @input/@output shape)
shared its operation ID with the next shape. One of the two operations then
replaced the other, and shapes only it reached were silently left out of
models.py. Increment the index once per operation and test that every error
and structure is generated.
CreateSyntheticService included @input and @output structures when
generateInputsAndOutputs was set, but DirectedPythonTypeCodegen always
skipped them in types mode, so the setting had no effect. Pass the setting
to the generator and generate those structures when it is on. Also list
selector and generateInputsAndOutputs as known settings so using them no
longer logs an additional-properties warning.
@stobrien89

Copy link
Copy Markdown
Contributor Author

#928 has been merged

@stobrien89 stobrien89 closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants