Repository navigation
[Mirror of #928] Give every shape its own synthetic operation in python-type-codegen - #953
Closed
stobrien89 wants to merge 2 commits into
Closed
stobrien89 wants to merge 2 commits into
stobrien89 wants to merge 2 commits into
Conversation
CreateSyntheticService incremented the operation index only for shapes that get a synthetic input wrapper, so an error (or a kept @input/@output shape) shared its operation ID with the next shape. One of the two operations then replaced the other, and shapes only it reached were silently left out of models.py. Increment the index once per operation and test that every error and structure is generated.
CreateSyntheticService included @input and @output structures when generateInputsAndOutputs was set, but DirectedPythonTypeCodegen always skipped them in types mode, so the setting had no effect. Pass the setting to the generator and generate those structures when it is on. Also list selector and generateInputsAndOutputs as known settings so using them no longer logs an additional-properties warning.
Contributor
Author
|
#928 has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Mirrors #928 from a branch in this repo so the
aws-sdk-pr-buildworkflow runs. Not for merging; review and merge #928.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.