Add codegen-output folder for visual diff inspection - #802
Merged
Merged
Conversation
kuhe
force-pushed
the
kuhe/chore/visual-diff
branch
from
September 21, 2026 16:25
685cfe5 to
f2cfd63
Compare
chore: deterministic recursive-member ordering + formatted golden snapshot
kuhe
force-pushed
the
kuhe/chore/visual-diff
branch
from
September 21, 2026 16:36
f2cfd63 to
054a936
Compare
jonathan343
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codegen-output.Why?
When I modify codegen logic, I want to immediately see what the consequence is, before AWS SDK becomes liable for the diff.
Intentional changes to codegen output, the runtime clients, will become visible and confirmable in all PRs.
This also immediately caught that deferred member generation wasn't deterministic, which is also fixed in the PR.