Mock PermissionError in config file permission test#750
Merged
Conversation
chmod(0o000) is bypassed when tests run as root (e.g. in CI), so the file was still readable and the test failed. Patch Path.read_text to raise PermissionError instead, exercising the error-handling branch deterministically regardless of user.
alexgromero
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
test_permission_denied_returns_emptyfailing in release infra by mocking thePermissionErrorinstead of relying on filesystem permission bits.Issue
The test used
chmod(0o000)to make a config file unreadable, expectingparse_config_fileto catch aPermissionErrorand return{}. This passed locally but failed in release infra because CI runs tests as root, which bypasses Unix permission bits. The read succeeded, the file was parsed, and the result was{'profile default': {'region': 'us-east-1'}}instead of{}.Solution
Replace the
chmodwithpatch.object(Path, "read_text", side_effect=PermissionError(...)). This deterministically exercises theexcept (PermissionError, OSError)branch regardless of the running user, and matches the mocking approach already used intest_config_file_location.py.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.