buildroot: drop the inert BR2_EXTERNAL_DIRS=.. from the build - #336
Merged
Merged
Conversation
BR2_EXTERNAL_DIRS is generated by buildroot from BR2_EXTERNAL; passing it on the command line registers no external tree. BR2_EXTERNAL_NAMES and BR2_EXTERNAL_MKS stay empty, and the package infrastructure iterates over BR2_EXTERNAL_NAMES, not over BR2_EXTERNAL_DIRS. Its only two consumers are out of reach here: the %_defconfig rule, which this invocation does not target (do_configure passes no such variable), and an include of $(dir)/docs/*/*.mk, which does not exist under the output directory. Diffing the complete make variable database with and without the flag shows a single difference out of 314601 entries: the variable itself. The rootfs overlays and post_image.sh are reached by the defconfig through $(BASE_DIR)/board/..., not by any br2-external mechanism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BR2_EXTERNAL_DIRSis generated by buildroot fromBR2_EXTERNAL. Passing it onthe
makecommand line registers no external tree:BR2_EXTERNAL_NAMESandBR2_EXTERNAL_MKSstay empty, and the package infrastructure iterates overBR2_EXTERNAL_NAMES— the Makefile says so itself at line 1237.Its only two consumers are out of reach here:
%_defconfigrule (Makefile:1027), which this invocation does not target —do_configurerunsmake O=… BR2_DL_DIR=… <plat>_defconfigwith no suchvariable;
-include $(foreach dir,$(BR2_EXTERNAL_DIRS),$(wildcard $(dir)/docs/*/*.mk))(Makefile:1272) — there is no
docs/under the output directory.Evidence: diffing the complete make variable database (
make printvars VARS='%')with and without the flag gives one differing line out of 314601 — the
variable itself. Nothing derives from it.
The rootfs overlays and
post_image.share reached by the defconfig through$(BASE_DIR)/board/…, not by any br2-external mechanism. Keeping the flag onlyinvites the misreading that
board/is a BR2_EXTERNAL tree; it is not.🤖 Generated with Claude Code