Futex syscall implementation #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
The implementation uses lists Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
clemdiep
requested changes
Nov 10, 2025
Contributor
clemdiep
left a comment
clemdiep
left a comment
There was a problem hiding this comment.
Overall, this seems ok. Just some small improvements
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
| /* no futex on futex_w */ | ||
| futex = (futex_t *) calloc(1, sizeof(futex_t)); | ||
| if (futex == NULL) | ||
| BUG(); |
Contributor
There was a problem hiding this comment.
Should also returned -EINVAL
Contributor
Author
There was a problem hiding this comment.
It is to indicate that calloc failed. Usually we put BUG().
clemdiep
requested changes
Nov 11, 2025
Contributor
clemdiep
left a comment
clemdiep
left a comment
There was a problem hiding this comment.
Last small fix and then all good
Signed-off-by: Jean-Pierre Miceli <jean-pierre.miceli@heig-vd.ch>
clemdiep
approved these changes
Nov 12, 2025
daniel-rossier
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic
futexsyscall implementation.It does only supports
FUTEX_WAITandFUTEX_WAKEoperation.The implementation uses lists. It can be improved using hash table later.